Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Option Private Module #251

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DecimalTurn
Copy link

@DecimalTurn DecimalTurn commented Mar 18, 2023

This PR aims at fixing an issue mainly with Excel where the functions defined in JsonConverter.bas appear as Excel functions in the autocompletion suggestions and in the Insert Function Window.
image
image

Important note:
The Option Private Module only prevents access from outide the VBA project. Hence, this won't affect normal use of VBA-JSON as explained in the documentation :

When a module contains Option Private Module, the public parts, for example, variables, objects, and user-defined types declared at the module level, are still available within the project containing the module, but they are not available to other applications or projects.

The only way this could affect negatively someone would be if they were calling JsonConverter's code from another VBProject. However, considering that JsonConverter is easily portable accross project, it's a much better practice to have a copy of it inside the project instead of having an external reference anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant